Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add case insensitivity to insert #602

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Add case insensitivity to insert #602

merged 1 commit into from
Nov 2, 2021

Conversation

VinaiRachakonda
Copy link
Contributor

No description provided.

@VinaiRachakonda VinaiRachakonda mentioned this pull request Oct 28, 2021
Closed
zachmu
zachmu approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@zachmu
Copy link
Member

zachmu commented Nov 2, 2021

You should follow up with similar tests for update, not sure if it's covered or not

@VinaiRachakonda VinaiRachakonda merged commit 59178ea into main Nov 2, 2021
@VinaiRachakonda
Copy link
Contributor Author

Added a test in pr for update. Seems to be fine

@Hydrocharged Hydrocharged deleted the vinai/case_insensitivity branch December 8, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees

@zachmu zachmu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VinaiRachakonda @zachmu