Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some expressions not using the largest partial index #632

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Fixed some expressions not using the largest partial index #632

merged 1 commit into from
Nov 18, 2021

Conversation

Hydrocharged
Copy link
Contributor

No description provided.

zachmu
zachmu approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good, but would like to see more testing. In particular, should have an engine test for this, including a query plan test. Might need to add a new table to test_data.go (one with 3+ columns in an index)

sql/analyzer/index_analyzer_test.go Show resolved Hide resolved
@Hydrocharged Hydrocharged force-pushed the daylon/partial-choosing branch 2 times, most recently from 7ec5b35 to 9d496af Compare November 18, 2021 13:40
@Hydrocharged Hydrocharged merged commit 5cefad4 into main Nov 18, 2021
@Hydrocharged Hydrocharged deleted the daylon/partial-choosing branch November 18, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hydrocharged @zachmu