Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server event listener #685

Merged
merged 7 commits into from
Dec 16, 2021
Merged

server event listener #685

merged 7 commits into from
Dec 16, 2021

Conversation

bheni
Copy link
Contributor

@bheni bheni commented Dec 14, 2021

No description provided.

zachmu
zachmu approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, although it seems like you want a little more info on these events

server/server.go Show resolved Hide resolved
server/server.go Show resolved Hide resolved
@bheni bheni merged commit 71f612c into main Dec 16, 2021
@bheni bheni deleted the bh/server-event-listener branch December 16, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bheni @zachmu