Fix JSON Extract on structs. #698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was broken because the jsonpath library fails whenever the given object is not a slice or a map. Structs must thus be converted to map[string]interface{} JSON representation prior to jsonpath.Lookup being called.
|
Looks like this breaks a bunch of tests, although the change looks fine. Let us know if you need help debugging. |
|
@jennifersp can you evaluate this to see if the change is good, and then fix the tests if so? (and close this out if not) |
|
Was not able to push commit to this PR, so created PR fixes failing tests for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was broken because the jsonpath library fails whenever the given object is not a slice or a map. Structs must thus be converted to map[string]interface{} JSON representation prior to jsonpath.Lookup being called.