server/handler.go: Close the row iter in doQuery with the same context we run the query with. #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t we run the query with. If a row iter implementation captures the |ctx| from RowIter() or Next() calls, and that |ctx| is canceled before the Close() call happens, then the implementation may return an error on the canceled context. It is better for our existing implementations if the Close() calls happen with the same context as RowIter() and Next().
Hydrocharged
deleted the
aaron/server-handler-close-row-iter-with-errgroup-ctx
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a row iter implementation captures the |ctx| from RowIter() or Next() calls,
and that |ctx| is canceled before the Close() call happens, then the
implementation may return an error on the canceled context. It is better for
our existing implementations if the Close() calls happen with the same context
as RowIter() and Next().