Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lag function. #715

Merged
merged 4 commits into from
Jan 5, 2022
Merged

Add lag function. #715

merged 4 commits into from
Jan 5, 2022

Conversation

max-hoffman
Copy link
Contributor

Spec: LAG(expr, offset(default = 1), default(default=nil)).

@max-hoffman
Add lag function.
8c71d66 
Spec: LAG(expr, offset(default = 1), default(default=nil)).
@max-hoffman
test edits
f8c701c
@max-hoffman max-hoffman mentioned this pull request Jan 4, 2022
Closed
zachmu
zachmu approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor comments

sql/expression/function/aggregation/window/lag.go Outdated Show resolved Hide resolved
sql/expression/function/aggregation/window/lag.go Show resolved Hide resolved
sql/expression/function/aggregation/window/lag.go Outdated Show resolved Hide resolved
sql/expression/function/aggregation/window/lag.go Outdated Show resolved Hide resolved
sql/expression/function/aggregation/window/lag.go Outdated Show resolved Hide resolved
@max-hoffman max-hoffman merged commit 198813e into main Jan 5, 2022
@max-hoffman max-hoffman deleted the max/lag-fn branch January 5, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees

@zachmu zachmu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-hoffman @zachmu