GroupBy normalization rule maintains parent Projection dependencies #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Jan 25, 2022
sql/analyzer/aggregations.go
Outdated
| @@ -75,13 +75,18 @@ func flattenedGroupBy(ctx *sql.Context, projection, grouping []sql.Expression, c | |||
| func replaceAggregatesWithGetFieldProjections(ctx *sql.Context, projection []sql.Expression) (projections, aggregations []sql.Expression, err error) { | |||
| var newProjection = make([]sql.Expression, len(projection)) | |||
| var newAggregates []sql.Expression | |||
|
|
|||
| allGetFields := make(map[int]sql.Expression, 0) | |||
There was a problem hiding this comment.
No need to declare size zero in map initializers like this.
Generally speaking the only time you want to explicitly size a map or slice is when you know ahead of time how big it will be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We flatten GroupBy aggregations to isolation agg functions, but in the process lose nested column dependencies. The downstream
qualifyColumnsrule was erroring, but without passthrough projections binary expressions likeArithemtic(Sum(x.i), y.i)will fail at execution time without a full set of input dependencies.For this query:`
We correctly identify that the GroupBy node has one primary aggregation, Sum, and project the Arithmetic separately.
The
Projectnode fails downstream trying to lookup they.idependency we discarded in the transform. This PR adds dependencies back to cover the new parentProjectforGroupByflattening.