Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for non-string key types in JSON_OBJECT #756

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Adding support for non-string key types in JSON_OBJECT #756

merged 3 commits into from
Jan 25, 2022

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jan 25, 2022

Resolves: dolthub/dolt#2626

@fulghum fulghum requested a review from zachmu January 25, 2022 00:16
zachmu
zachmu approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment

sql/expression/function/json_object.go Outdated Show resolved Hide resolved
@fulghum fulghum merged commit ffbf7f4 into dolthub:main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error invalid type: INT when selecting from view
2 participants
@fulghum @zachmu