Window frame support #764
Merged
Window frame support #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
commented
Jan 27, 2022
| @@ -21,3 +21,17 @@ when the opportunities arise. | |||
| If we end up using more of cockroach DB's optimizer, they codegen their | |||
| expressions, normalization rules, exploration rules, and execution code | |||
| stem from this general setup. | |||
|
|
|||
| ## Generators | |||
There was a problem hiding this comment.
@zachmu summary of codegen
max-hoffman
commented
Jan 27, 2022
| @@ -166,6 +166,19 @@ type WindowFramer interface { | |||
| //SlidingInterval(ctx Context) (WindowInterval, WindowInterval, WindowInterval) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
@zachmu this is important, will add doc comments
max-hoffman
commented
Jan 27, 2022
| @@ -255,3 +257,162 @@ func (f *GroupByFramer) Interval() (sql.WindowInterval, error) { | |||
| func (f *GroupByFramer) SlidingInterval(ctx sql.Context) (sql.WindowInterval, sql.WindowInterval, sql.WindowInterval) { | |||
| panic("implement me") | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
@zachmu this is the point of failure for ROWS frame correctness
max-hoffman
commented
Jan 27, 2022
| ) | ||
|
|
||
| //go:generate optgen -out window_frame_factory.og.go -pkg parse frameFactory window_frame_factory.go | ||
|
|
There was a problem hiding this comment.
@zachmu this is the bottleneck for AST -> plan node correctness
zachmu
approved these changes
Jan 27, 2022
| unboundedPreceding bool | ||
| startCurrentRow bool | ||
| endCurrentRow bool | ||
| startPrecedingExpr int |
There was a problem hiding this comment.
Odd to call these expr when they are ints
There was a problem hiding this comment.
what if i called them both startNPreceding?
This PR adds sql.WindowFrame and sql.WindowFramers to represent window frames from AST -> plan -> exec. Every unique and valid combination of window frame Start and End bounds has a plan node (sql.WindowFrame) and a framer (sql.WindowFramer) pair. The frames, framers, and constructor functions that map from AST -> plan and plan -> exec are generated by optgen. Only rowFrameBase implemented in this PR, range frame tests are commented out until rangeFrameBase is implemented.
max-hoffman
force-pushed
the
max/window-frames
branch
from
2274082
to
24a5593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sql.WindowFrame and sql.WindowFramers to represent
window frames from AST -> plan -> exec.
Every unique and valid combination of window frame
Start and End bounds has a plan node (sql.WindowFrame)
and a framer (sql.WindowFramer) pair. The frames, framers,
and constructor functions that map from AST -> plan and
plan -> exec are generated by optgen.