Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sql.FilteredIndex to allow integrators to specify index filter pushdowns #850

Merged
merged 4 commits into from
Mar 4, 2022

Conversation

andy-wm-arthur
Copy link
Contributor

No description provided.

@andy-wm-arthur andy-wm-arthur marked this pull request as ready for review March 4, 2022 18:12
…ssions, regenerated index query plan tests with more filters removed
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, everything here looks straightforward but sometimes Dolt can be more demanding than the memory integrator, would suggest a sanity check Dolt PR between the main branches before merging

return nil, nil
}

a.Log(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be useful to log more info, like the lookup expr when it's non-nil and the handled subset. if the two don't overlap it will stick out in debug logs. would have saved us both some trouble.

@andy-wm-arthur andy-wm-arthur merged commit 4d7d9a2 into main Mar 4, 2022
@andy-wm-arthur andy-wm-arthur deleted the andy/filtered-indexes branch March 4, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants