Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransformUp is now sensitive to tree modifications #867

Merged
merged 13 commits into from
Apr 1, 2022
Merged

TransformUp is now sensitive to tree modifications #867

merged 13 commits into from
Apr 1, 2022

Commits on Mar 17, 2022

  1. TransformUp now sensitive to tree modifications 

    `TransformUp` and related node/expression DFS helper functions expect the
visit function to return an additional parameter indicating
whether the visit changed the node: `sql.SameTree` or `sql.NewTree`.

We use `plan.InspectUp` when possible, and then `plan.TransformUp` where
possible, resorting to the more expensive `plan.TransformUpCtx` and
`plan.TransformUpCtxSchema` only when necessary.
    @max-hoffman
    max-hoffman committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    ceb8e26 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. progress for nodesEqual refactor

    @max-hoffman
    max-hoffman committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    8eaaad0 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. prog

    @max-hoffman
    max-hoffman committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    3119cde View commit details
    Browse the repository at this point in the history

  2. merge main

    @max-hoffman
    max-hoffman committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    9e84074 View commit details
    Browse the repository at this point in the history

  3. renames

    @max-hoffman
    max-hoffman committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    4d662e5 View commit details
    Browse the repository at this point in the history

  4. fixup names more

    @max-hoffman
    max-hoffman committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    bd8b460 View commit details
    Browse the repository at this point in the history

  5. Move transform related interfaces into transform package

    @max-hoffman
    max-hoffman committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    efa705e View commit details
    Browse the repository at this point in the history

  6. [ga-format-pr] Run ./format_repo.sh to fix formatting

    @max-hoffman
    max-hoffman committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    856fc62 View commit details
    Browse the repository at this point in the history

  7. missing docstring

    @max-hoffman
    max-hoffman committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    408bb69 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'max/reduce-transform-mallocs' of github.com:dolthub/go-… 

    …mysql-server into max/reduce-transform-mallocs
    @max-hoffman
    max-hoffman committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    01ca96a View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2022

  1. prog

    @max-hoffman
    max-hoffman committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    3b9d6ba View commit details
    Browse the repository at this point in the history

  2. merge main

    @max-hoffman
    max-hoffman committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    8063875 View commit details
    Browse the repository at this point in the history

  3. Zach's comments

    @max-hoffman
    max-hoffman committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    e10499f View commit details
    Browse the repository at this point in the history