Apply bindvars to subqueries #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Mar 14, 2022
sql/plan/transform.go
Outdated
| // TransformUpWithOpaque applies a transformation function to the given tree from the bottom up, including through | ||
| // opaque nodes. This method is generally not safe to use for a transformation. Opaque nodes need to be considered in | ||
| // isolation except for very specific exceptions. | ||
| // TODO: a better way to do this might be to keep the WITH nodes around until the very end of anlysis, so that |
There was a problem hiding this comment.
Remove this TODO, doesn't make sense in isolation
sql/plan/bindvar.go
Outdated
|
|
||
| return TransformUpWithOpaque(n, func(node sql.Node) (sql.Node, error) { | ||
| switch n := node.(type) { | ||
| case *IndexedJoin: |
There was a problem hiding this comment.
This seems misplaced, left over from other PR?
sql/plan/bindvar.go
Outdated
| } | ||
| return e, nil | ||
| return TransformExpressionsUp(node, fixBindings) |
There was a problem hiding this comment.
Should be a default label rather than outside the switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from #795 to fix Subquery bindvars specficially.