Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added warnings for some syntaxes of ALTER TABLE and CREATE DATABASE statements #884

Merged
merged 4 commits into from
Mar 18, 2022
Merged

added warnings for some syntaxes of ALTER TABLE and CREATE DATABASE statements #884

merged 4 commits into from
Mar 18, 2022

Conversation

jennifersp
Copy link
Contributor

  • Added a warning for using CHARACTER SET, COLLATE or ENCRYPTION syntaxes when creating database. The database is still created.
  • Added a warning for using DISABLE KEYS or ENABLE KEYS options for alter table statement. Nothing changes for the table being altered.
  • Added a system variable that mysqldump uses, innodb_stats_auto_recalc

VinaiRachakonda
VinaiRachakonda reviewed Mar 18, 2022
View reviewed changes
sql/parse/parse.go Outdated Show resolved Hide resolved
@VinaiRachakonda
Copy link
Contributor

LGTM!

@jennifersp jennifersp merged commit 93a6edd into main Mar 18, 2022
@jennifersp jennifersp deleted the jennifer/mysqldump branch March 18, 2022 17:50
@jennifersp jennifersp mentioned this pull request Mar 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinaiRachakonda VinaiRachakonda VinaiRachakonda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennifersp @VinaiRachakonda