Allow auto_increment on non-primary key columns
#936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
April 4, 2022 11:26
sql/index.go
Outdated
| @@ -49,6 +49,8 @@ type Index interface { | |||
| // ColumnExpressionTypes returns each expression and its associated Type. Each expression string should exactly | |||
| // match the string returned from Index.Expressions(). | |||
| ColumnExpressionTypes(ctx *Context) []ColumnExpressionType | |||
| // ColumnNames returns the names of the Columns that this Index is defined over | |||
| ColumnNames() []string | |||
There was a problem hiding this comment.
This method is effectively a duplicate of Expressions() []string. Instead of adding ColumnNames(), you should use the Expressions() in combination with GetColumnFromIndExpr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: dolthub/dolt#2981
Since Unique Keys are not a part of
sql.Schemaandsql.Column, we need to check if there are any valid indexes defined over the columns we want to mark asauto_increment.Added skipped tests for queries that don't work.
TODO:
auto_incrementaddsNOT NULLconstraint tooalter table t add column j int uniquefirstauto_incremented