Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checks for unique index #952

Merged
merged 6 commits into from
Apr 20, 2022
Merged

Remove checks for unique index #952

merged 6 commits into from
Apr 20, 2022

Conversation

VinaiRachakonda
Copy link
Contributor

@VinaiRachakonda VinaiRachakonda commented Apr 13, 2022 •
edited
Loading

We should follow up with an implementation for a unique index for the memory table. Will take a crack at this in a future edit.

max-hoffman
max-hoffman approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for reformatting the tests!

@VinaiRachakonda VinaiRachakonda merged commit 264e64b into main Apr 20, 2022
@Hydrocharged Hydrocharged deleted the vinai/allow-unique-indexes branch October 13, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VinaiRachakonda @max-hoffman