support handling join table between parentheses #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifersp
changed the title
max-hoffman
reviewed
Apr 21, 2022
max-hoffman
reviewed
Apr 21, 2022
max-hoffman
reviewed
Apr 22, 2022
max-hoffman
reviewed
Apr 22, 2022
max-hoffman
approved these changes
Apr 22, 2022
|
Does this also fix dolthub/dolt#2203? It appears to be related. But please note that the parentheses have "semantics" and mustn't simply be ignored. |
You're right! It does fix this issue as well. Thanks for catching it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow handling join tables in parentheses. It causes the JoinTableExpr to be wrapped in ParenTableExpr in the parser, so it needs to be unwrapped to get the JoinTableExpr inside
Fixes dolthub/dolt#3254