changed to parse empty columns; fixed formatting for empty columns

dolthub · Nov 19, 2021 · e3533db · e3533db
1 parent 006e9b3
commit e3533db
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/go/vt/sqlparser/ast.go b/go/vt/sqlparser/ast.go
@@ -3057,7 +3057,8 @@ func (node Columns) Format(buf *TrackedBuffer) {
 	if node == nil {
 		return
 	}
-	prefix := "("
+	buf.WriteString("(")
+	prefix := ""
 	for _, n := range node {
 		buf.Myprintf("%s%v", prefix, n)
 		prefix = ", "

diff --git a/go/vt/sqlparser/parse_test.go b/go/vt/sqlparser/parse_test.go
@@ -2611,10 +2611,10 @@ func TestKeywords(t *testing.T) {
 			output: "insert into t(a, b) values ('a', 'b')",
 		}, {
 			input: "insert into t() values ()",
-			output: "insert into t values ()",
+			output: "insert into t() values ()",
 		}, {
 			input: "insert into t() values (), (), ()",
-			output: "insert into t values (), (), ()",
+			output: "insert into t() values (), (), ()",
 		}, {
 			input: "select * from t where a > utc_timestmp()",
 		}, {

diff --git a/go/vt/sqlparser/sql.go b/go/vt/sqlparser/sql.go
diff --git a/go/vt/sqlparser/sql.y b/go/vt/sqlparser/sql.y
@@ -4398,7 +4398,7 @@ insert_data:
   }
 | openb closeb VALUES tuple_list
   {
-    $$ = &Insert{Rows: $4}
+    $$ = &Insert{Columns: []ColIdent{}, Rows: $4}
   }
 | select_statement
   {