Window function frames, extent, and bounds #104
Conversation
max-hoffman
force-pushed
the
max/basic-window-frames
branch
from
a4c4d3f
to
1c3abe2
Compare
max-hoffman
changed the title
Adds parsing capabilities for window frames, including one sided frames, two sided frames, RANGE value frames, integral and interval based frames, and errors for semantically incorect combinations of frame options. Only value based intervals are currently supported. Prepared bound expressions are not supported.
max-hoffman
force-pushed
the
max/basic-window-frames
branch
from
a6b1b51
to
dcfa863
Compare
go/vt/sqlparser/ast.go
Outdated
| } | ||
|
|
||
| // Format formats the node. | ||
| func (node *FrameBound) print(buf *TrackedBuffer) { |
There was a problem hiding this comment.
should FrameBound implement Node? the Format function would be empty, but it's useful in the AST
There was a problem hiding this comment.
Why would the format function be empty? It has a textual representation, right?
There was a problem hiding this comment.
was confused, realize now that node printing is recursive
max-hoffman
force-pushed
the
max/basic-window-frames
branch
from
5cc057d
to
4cf6dff
Compare
| } | ||
|
|
||
| // Format formats the node. | ||
| func (node *Frame) Format(buf *TrackedBuffer) { |
There was a problem hiding this comment.
Not printing Extent here is a red flag
There was a problem hiding this comment.
I don't actually know how these tests pass
There was a problem hiding this comment.
The reason they pass is because you have been fooled: in these tests, select expressions echo their textual input unless you tell the test case serializeSelectExprs: true
When you add that to one of these cases, you can see they don't actually work, no range info is printed:
expected: "select name, dense_rank() over (partition by x order by y RANGE BETWEEN 1 PRECEDING AND 1 FOLLOWING) from t"
actual : "select name, dense_rank() over (partition by x order by y asc) from t"
From a brief look, it seems most of the OVER tests have this issue
There was a problem hiding this comment.
the opposite is now default, need to specify useSelectExpressionLiteral to sidestep parsing
go/vt/sqlparser/ast.go
Outdated
| } | ||
|
|
||
| // Format formats the node. | ||
| func (node *FrameBound) print(buf *TrackedBuffer) { |
There was a problem hiding this comment.
Why would the format function be empty? It has a textual representation, right?
Signed-off-by: Max Hoffman <max@dolthub.com>
Adds parsing capabilities for window frames, including one sided frames, two sided frames, RANGE value frames, integral and interval based frames, and errors for semantically incorect combinations of frame options. Only value based intervals are currently supported. No prepared statement support for expression bounds.