Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/vt/sqlparser: Remove PartialDDL support. #107

Merged
merged 2 commits into from
Jan 3, 2022
Merged

go/vt/sqlparser: Remove PartialDDL support. #107

merged 2 commits into from
Jan 3, 2022

Conversation

reltuk
Copy link

@reltuk reltuk commented Dec 20, 2021

There's no need to support partial DDL in dolt.

@reltuk reltuk requested a review from zachmu December 20, 2021 18:35
zachmu
zachmu approved these changes Jan 1, 2022
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM

But I also think you should get rid of the ddl_skip_to_end token in sql.y. Could be done as a separate pass, as that probably breaks some badly written tests

@reltuk reltuk merged commit a8c7f50 into main Jan 3, 2022
@Hydrocharged Hydrocharged deleted the aaron/remove-partial-ddl-support branch October 13, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees

@zachmu zachmu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reltuk @zachmu