Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show like status #121

Merged
merged 4 commits into from
Feb 15, 2022
Merged

Add show like status #121

merged 4 commits into from
Feb 15, 2022

Conversation

VinaiRachakonda
Copy link

No description provided.

Copy link

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just add tests that verify the range of expected behavior before merging, and maybe a failure test for not supporting naked likes

@@ -1423,6 +1423,9 @@ var (
}, {
input: "show session status",
output: "show session status",
}, {
input: "show session status LIKE 'Ssl_cipher'",
output: "show session status like 'Ssl_cipher'",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add tests for a LIKE with a %, a naked like without quotes, and some of the where examples in docs https://dev.mysql.com/doc/refman/8.0/en/extended-show.html

@VinaiRachakonda VinaiRachakonda merged commit b3d3007 into main Feb 15, 2022
@Hydrocharged Hydrocharged deleted the vinai/show-session-status-like branch October 13, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants