Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return Into value in GetInto() in SelectStatement #160

Merged
merged 3 commits into from
May 4, 2022
Merged

Conversation

jennifersp
Copy link

This allows to get Into value without doing switch on its types.

@jennifersp jennifersp requested a review from fulghum May 4, 2022 16:51
@jennifersp jennifersp requested a review from zachmu as a code owner May 4, 2022 16:51
go/vt/sqlparser/ast.go Outdated Show resolved Hide resolved
Copy link

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@jennifersp jennifersp merged commit 70dd916 into main May 4, 2022
@jennifersp jennifersp deleted the jennifer/fix branch May 4, 2022 22:07
@jennifersp jennifersp changed the title return Into value in HasIntoDefined() in SelectStatement return Into value in GetInto() in SelectStatement May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants