Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for specifying a primary key name #169

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Conversation

fulghum
Copy link

@fulghum fulghum commented Jun 23, 2022

MySQL allows you to specify an optional name following a primary key definition when creating or altering a table. This name is always ignored though – all primary keys in MySQL are always named PRIMARY.

Fixes: dolthub/dolt#3674

@fulghum fulghum requested a review from zachmu as a code owner June 23, 2022 20:54
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fulghum fulghum merged commit fa8f68c into main Jun 23, 2022
@fulghum fulghum deleted the fulghum/issue-3674 branch June 23, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dolt doesn't create named primary key
2 participants