Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Varchar(MAX) #188

Merged
merged 6 commits into from
Sep 15, 2022
Merged

Support Varchar(MAX) #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
824eb48
init parse max
Sep 12, 2022
0004671
Implement parse MAX and add unit test
rafimuhammad01 Sep 12, 2022
a34a0e5
Delete unused token VAR_MAX
rafimuhammad01 Sep 12, 2022
5fc8b43
Change variable name to char_length_opt and minor changes
rafimuhammad01 Sep 13, 2022
29c66b5
Merge branch 'main' into feat/support-varchar-max
fulghum Sep 15, 2022
936a72b
regen'ing sql.go
fulghum Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions go/vt/sqlparser/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4368,6 +4368,7 @@ func TestCreateTable(t *testing.T) {
" col_varchar3 varchar(3) character set ascii,\n" +
" col_varchar4 varchar(4) character set ascii collate ascii_bin,\n" +
" col_varchar5 varchar(5) character set ascii binary,\n" +
" col_varcharMax varchar(MAX),\n" +
" col_character_varying character varying,\n" +
" col_character_varying2 character varying(2),\n" +
" col_character_varying3 character varying(3) character set ascii,\n" +
Expand Down Expand Up @@ -4572,6 +4573,10 @@ func TestCreateTable(t *testing.T) {
input string
output string
}{{
// Tet varchar (MAX) syntax
input: "create table t (username varchar(MAX))",
output: "create table t (\n\tusername varchar(MAX)\n)",
}, {
// Test the signed keyword – as the default for numeric types, it is a no-op
input: "create table t (pk int signed primary key)",
output: "create table t (\n\tpk int primary key\n)",
Expand Down
Loading