Grammar fixes for customer issue using non-reserved keywords in insert into statements
#189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quoted) keyword is used in a list of columns in an insert into statement.
- renaming column_name_safe_reserved_keyword to column_name_safe_keyword, since the contents are keywords, not "reserved" keywords that need to be backtick quoted - fixing a bug with recursion for insert into column names (ins_column_list rule) - removing avg,count,sum,min,max from lists of reserved keywords, since they are not reserved in MySQL and can parse correctly in tests.
zachmu
approved these changes
Sep 15, 2022
go/vt/sqlparser/parse_test.go
Outdated
| iTest := "INSERT INTO t (%s) VALUES (1)" | ||
| iTest1 := "INSERT INTO t_t (%s) VALUES ('one')" | ||
| iTest2 := "INSERT INTO t_t (pk, %s) VALUES (1, 'one')" | ||
| iTest3 := "INSERT INTO t_t (pk, %s, c1) VALUES ('one', 1)" |
There was a problem hiding this comment.
Might change this to have the right number of values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer reported an issue on Discord with using
insert into t(pk, comment) values (1, 1). Comment is a keyword, but not a reserved keyword, so this is valid syntax, but our parser was failing on it.A few changes to tidy up:
column_name_safe_reserved_keywordtocolumn_name_safe_keyword, since the contents are keywords, but are not "reserved" keywords that need to be backtick quotedins_column_listrule)avg,count,sum,min,maxfrom lists of reserved keywords, since they are not reserved in MySQL and can parse correctly in tests without being backtick quoted.