Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/mysql: query.go: Put strings into BindVars as copies, not slices of the recyclable wire packet buffers. #191

Merged
merged 1 commit into from
Sep 21, 2022
Merged

go/mysql: query.go: Put strings into BindVars as copies, not slices of the recyclable wire packet buffers. #191

merged 1 commit into from
Sep 21, 2022

Conversation

reltuk
Copy link

@reltuk reltuk commented Sep 21, 2022

Cherry picks vitessio#5562.

@reltuk
go/mysql: query.go: Put strings into BindVars as copies, not slices o…
ecffe52 
…f the recyclable wire packet buffers.

Cherry picks vitessio#5562.
@reltuk reltuk requested a review from zachmu as a code owner September 21, 2022 21:18
zachmu
zachmu approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reltuk reltuk merged commit 1df8e46 into main Sep 21, 2022
@Hydrocharged Hydrocharged deleted the cherry-pick-5562 branch October 13, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reltuk @zachmu