Support calling procedures from specified database. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
Code changes look great! We should figure out the failing CI test before we merge though... I wasn't able to repro that failure locally (TestTLSRequired), although I did see a different test failing for me locally that's not failing in CI (TestNullsafeAdd). 🤷♂️
Looks like there will need to be a coordinate change to GMS for the Call.FuncName -> Call.ProcName change, so would be good to get that staged and ready to go before we merge this one in, too.
PavelSafronov
force-pushed
the
pavel/call-qualified-procs
branch
from
a8f2c3e
to
38c0ad3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support calling procedures from specified database, for example
call mydb.test();Related Issue(s)
This fixes dolthub/dolt#4725
Checklist
Deployment Notes
No deployment notes, this adds missing SQL support.