Add TRIM functionality #88
Conversation
go/vt/sqlparser/ast.go
Outdated
| type TrimExpr struct { | ||
| Str Expr | ||
| Pattern Expr | ||
| Dir Expr |
There was a problem hiding this comment.
Should make this a string and define const values for it (LEADING, TRAILING, BOTH)
go/vt/sqlparser/sql.y
Outdated
| { | ||
| $$ = &TrimExpr{Pattern: NewStrVal([]byte(" ")), Str: $3, Dir: NewStrVal([]byte("b"))} | ||
| } | ||
| | TRIM openb STRING FROM value_expression closeb |
There was a problem hiding this comment.
Does MySQL require this to a string literal, or can you use other expressions? Test and seee
There was a problem hiding this comment.
Yeah, it can take expressions:
mysql> SELECT TRIM(LEADING concat('x', 'x') FROM 'xxxbarxxx');
+-------------------------------------------------+
| TRIM(LEADING concat('x', 'x') FROM 'xxxbarxxx') |
+-------------------------------------------------+
| xbarxxx |
+-------------------------------------------------+
jycor
changed the title
| @@ -2643,8 +2643,8 @@ func TestKeywords(t *testing.T) { | |||
| input: "select /* share and mode as cols */ share, mode from t where share = 'foo'", | |||
| output: "select /* share and mode as cols */ `share`, `mode` from t where `share` = 'foo'", | |||
| }, { | |||
| input: "select /* unused keywords as cols */ write, virtual from t where trailing = 'foo'", | |||
| output: "select /* unused keywords as cols */ `write`, `virtual` from t where `trailing` = 'foo'", | |||
| input: "select /* unused keywords as cols */ write, virtual from t where varcharacter = 'foo'", | |||
There was a problem hiding this comment.
Comment still applies, you changed this test case and should put it back
go/vt/sqlparser/parse_test.go
Outdated
| testCases := []parseTest{ | ||
| { | ||
| input: `SELECT TRIM("foo")`, | ||
| output: `select trim('foo', ' ', b) from dual`, |
There was a problem hiding this comment.
So generally speaking, the Format function should produce output which is itself parseable, and this won't
Unless you have a good reason not to do it this way instead, you should change the Format function to return something similar to the input
| type TrimExpr struct { | ||
| Str Expr | ||
| Pattern Expr | ||
| Dir string |
There was a problem hiding this comment.
Declare some exported constants for this value
go/vt/sqlparser/sql.y
Outdated
| @@ -3889,6 +3890,26 @@ function_call_keyword: | |||
| { | |||
| $$ = &SubstrExpr{StrVal: NewStrVal($3), From: $5, To: $7} | |||
| } | |||
| | TRIM openb value_expression closeb | |||
| { | |||
| $$ = &TrimExpr{Pattern: NewStrVal([]byte(" ")), Str: $3, Dir: "b"} | |||
There was a problem hiding this comment.
Use the exported constants here rather than string literals
…ithub.com/dolthub/vitess into james/fix-2297-implement-string-functions
…ithub.com/dolthub/vitess into james/fix-2297-implement-string-functions
| @@ -2643,8 +2643,8 @@ func TestKeywords(t *testing.T) { | |||
| input: "select /* share and mode as cols */ share, mode from t where share = 'foo'", | |||
| output: "select /* share and mode as cols */ `share`, `mode` from t where `share` = 'foo'", | |||
| }, { | |||
| input: "select /* unused keywords as cols */ write, virtual from t where trailing = 'foo'", | |||
| output: "select /* unused keywords as cols */ `write`, `virtual` from t where `trailing` = 'foo'", | |||
| input: "select /* unused keywords as cols */ write, virtual from t where varcharacter = 'foo'", | |||
There was a problem hiding this comment.
Comment still applies, you changed this test case and should put it back
Changed sql.y to recognize keywords TRIM, LEADING, TRAILING, and BOTH