parser can detect insert into <table> () values <tuple_list> #92

jycor · 2021-11-19T21:11:41Z

added new case for insert_data
should be able to correctly parse
insert into test_tb values ()
insert into test_tb () values ()
insert into test_tb values (), (), ...
insert into test_tb () values (), (), ...

zachmu

LGTM

zachmu

LGTM

parser can detect insert into <table> () values <tuple_list>

0a8dd5a

jycor requested a review from zachmu as a code owner November 19, 2021 21:11

adding some parse test cases

006e9b3

zachmu approved these changes Nov 19, 2021

View reviewed changes

changed to parse empty columns; fixed formatting for empty columns

e3533db

zachmu approved these changes Nov 19, 2021

View reviewed changes

jycor merged commit ab01038 into main Nov 19, 2021

Hydrocharged deleted the james/fix-2420-support-empty-cols-and-vals branch October 13, 2022 12:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

parser can detect insert into <table> () values <tuple_list> #92

parser can detect insert into <table> () values <tuple_list> #92

jycor commented Nov 19, 2021 •

edited

Loading

zachmu left a comment

zachmu left a comment

parser can detect insert into <table> () values <tuple_list> #92

parser can detect insert into <table> () values <tuple_list> #92

Conversation

jycor commented Nov 19, 2021 • edited Loading

zachmu left a comment

Choose a reason for hiding this comment

zachmu left a comment

Choose a reason for hiding this comment

jycor commented Nov 19, 2021 •

edited

Loading