Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types with TryParse must be set with type string #3108

Conversation

jgarciadelanoceda
Copy link
Contributor

@jgarciadelanoceda jgarciadelanoceda commented Oct 11, 2024

Fixes #3105
It's not a full rollback of #2980.. But almost, now it takes into account the Enum if the apiParameter.Type is Enum

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (a42d8c9) to head (3c2802f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3108   +/-   ##
=======================================
  Coverage   90.50%   90.50%           
=======================================
  Files          76       76           
  Lines        3116     3116           
  Branches      515      516    +1     
=======================================
  Hits         2820     2820           
  Misses        296      296           
Flag Coverage Δ
Linux 90.50% <100.00%> (ø)
Windows 90.50% <100.00%> (ø)
macOS 90.50% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello added this to the v6.8.2 milestone Oct 11, 2024
@martincostello martincostello merged commit 349ba38 into domaindrivendev:master Oct 11, 2024
9 checks passed
@jgarciadelanoceda jgarciadelanoceda deleted the issue_3105_TypesWithTryParseMustBeSetAsString branch October 11, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants