added ignore case for loading records if file has a .bak extension #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikbraun
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Sorry for the delay for providing feedback and reviewing this - I've been very busy the last days launching Chefkoch PUR! 😄
LGTM 👍
|
No don't worry, I just hope lunch day was not on a Friday 😄 also I just saw that Chefkoch is using go, very interesting! |
|
We will never ever launch on Friday 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the func
loadFromRecordDirhas changed its behaviour I double checked that there are no other places the function is currently used. For future reference I included a comment stating that the func will ignore.bakfiles.closes point (2) from #161