Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Installation instructions out of date? #48

Closed
BevanR opened this issue May 6, 2019 · 2 comments · Fixed by #57
Closed

🐞 Installation instructions out of date? #48

BevanR opened this issue May 6, 2019 · 2 comments · Fixed by #57
Labels
type: documentation Indicates wrong, unclear, missing or hard to understand documentation

Comments

@BevanR
Copy link

BevanR commented May 6, 2019

After following the installation instructions from the README, npm run pretest fails;

$ npm list no-skipped-tests
my-project@1.0.125 ~/projects/my-project
└── no-skipped-tests@1.0.0

$ npm run pretest

> my-project@1.0.125 pretest ~/projects/my-project
> no-skipped-tests

sh: no-skipped-tests: command not found
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! my-project@1.0.125 pretest: `no-skipped-tests`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the my-project@1.0.125 pretest script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     ~/.npm/_logs/2019-05-06T02_17_06_493Z-debug.log
@BevanR BevanR changed the title Instalation instructions out of date? 🐞 Instalation instructions out of date? May 6, 2019
@dominique-mueller dominique-mueller changed the title 🐞 Instalation instructions out of date? 🐞 Installation instructions out of date? Apr 17, 2020
@dominique-mueller dominique-mueller added needs repro Indicates that this issue needs a reproduction before further steps can be taken support Indicates a request for help / clarification type: documentation Indicates wrong, unclear, missing or hard to understand documentation and removed needs repro Indicates that this issue needs a reproduction before further steps can be taken support Indicates a request for help / clarification labels Apr 17, 2020
@dominique-mueller
Copy link
Owner

Yes, you're right, the README has a copy-paste issue. You can of course run npm run pretest but only if that script is set up. Running the tool itself without that script can be done using npm run no-skipped-tests.

I'll fix it.

dominique-mueller added a commit that referenced this issue Mar 8, 2021
- Fix bin name
- Fix bin import
- Fix bin process exit code
- Fix docs

Closes #48.
@dominique-mueller
Copy link
Owner

Fixed and published with version 2.0.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Indicates wrong, unclear, missing or hard to understand documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants