V2 Fixes

[domluna]

fixes #878

     open(path, "w") do io
-        TOML.print(io, data)
+        return TOML.print(io, data)
     end

The return is no longer added for do expressions.

[ararslan]

The return is no longer added for do expressions.

Is it not possible to support that? It's a requirement for YASGuide.

[domluna]

The return is no longer added for do expressions.

Is it not possible to support that? It's a requirement for YASGuide.

Is the example above, with the return added, not a dealbreaker for YAS? It's really tricky to only add return in cases where not nothing is returned. I think in v1 this was broken in a bunch of ways but functional enough that it worked for most cases. In v2 this was fixed but the downside is that you get return TOML.print(io, data).

[ararslan]

It's really tricky to only add return in cases where not nothing is returned.

I'm not sure about the other style guides but at least for YAS the return is always required, even if it's nothing. In that example, return TOML.print(io, data) is correct for YAS. I'd probably personally write it as separate TOML.print(io, data) + return nothing but that's functionally equivalent and I wouldn't expect a formatter to be able to know that TOML.print is used for its side effects (writing to io) and not for its return value. Sounds like it's fully correct for YAS in v2 then?

[domluna]

It's really tricky to only add return in cases where not nothing is returned.

I'm not sure about the other style guides but at least for YAS the return is always required, even if it's nothing. In that example, return TOML.print(io, data) is correct for YAS. I'd probably personally write it as separate TOML.print(io, data) + return nothing but that's functionally equivalent and I wouldn't expect a formatter to be able to know that TOML.print is used for its side effects (writing to io) and not for its return value. Sounds like it's fully correct for YAS in v2 then?

I'll put this back in for YAS style.

I wouldn't expect a formatter to be able to know that TOML.print is used for its side effects (writing to io) and not for its return value.

right, we would need to do side effect analysis which is out of scope for a formatter from my PoV.

[domluna]

Merging this to master, still some things we can do but this had most of the fixes in.