-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some support for public
keyword
#886
Conversation
EDIT: boom it seems to work for me now, the spaces are back. |
public
keyword (wip)public
keyword
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you add tests? Then this looks good to go.
@domluna Hi! I added a very simple one following the other export test in tests, but is there any good way to add a comprehensive testset? I saw there's whole other packages imported in |
@domluna btw should I rebase this over the main branch? Having this over the other batch of fixes sounds sensible to me but should have asked. :D |
It should be fine - I'm just going to squash and merge it. Anything else you wanted to add or all good from your end? |
AFAIK all good, the main issue was not to mess up the formatting of Thanks! |
* fixes kwargs issues and returns being added to do expressions - we're just not doing that completely anymore * fix more issues * fix bug related to the whitespace_ops_in_indices option * revert multiline comments handling for now * add some support for `public` keyword (#886) * add some support for public keyword * fix the kset memberships for `public` * add a simple test * run public keyword test on 1.11+ * add always return for do blocks with yas style --------- Co-authored-by: Mirek Kratochvil <exa.exa@gmail.com>
Currently the
public
prints out a warning and formats in a pretty bad way (the space afterpublic
is removed, essentially merging the identifiers aspublic a
→publica
).This is an attempt to make it work, but it does not yet. Opening this for tracking; feel free to point out obvious issues that I missed. :)edited, seems to work now.