-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved get functions for easier access to fhem data #10
Conversation
Tx @Andre0512 , this looks like a good improvement. I will look over this during this weekend. |
Well, I reworked the code again and went one step further and replaced all get functions with my filter functions. Take a look at this and let me know if you think of a better naming for the functions or you want to do it with a different concept. Theoretically, a single get-function could be done and pass everything as a parameter or it could be even more differentiated into individual functions. I also implemented a conversion to float, int, and datetime. I could not find an existing function for it and I think my solution is not the best performer, but for that purpose it should be enough, I hope. That would have to be it then for my purpose at the moment. |
Tomorrow or Sunday I will ensure the compatibility with python2 and I will improve my documentation. |
This look like a nice extension. Ok, let me know when you're done with the changes. We would need:
and it would be nice, if I would then review and test your changes, and prepare a new version for PyPi and regenerate the documentation from source. |
Okay, I'm working on it. |
Done. You can start reviewing. 🙂 |
Hello, did you manage to have a look on it? Was everything fine? |
I am on it. Besides cosmetics, so far I have made one change to your parameter names, all nsomething parameters changed to not_something parameters for clarity. |
I integrated filter from fhem's devspec and give the probalby most used filters as parameters .
Also added functions to return only states or special readings/attributes/internals.