Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Le res #1

Merged
merged 10 commits into from
Dec 3, 2022
Merged

Le res #1

merged 10 commits into from
Dec 3, 2022

Conversation

donlinglok1
Copy link
Owner

No description provided.

@donlinglok1 donlinglok1 closed this Dec 2, 2022
@AugmentedRealityCat
Copy link
Collaborator

Is the LeRes code now included in the master branch ?

@donlinglok1
Copy link
Owner Author

Is the LeRes code now included in the master branch ?

no, I will keep 2 versions separately since the original project is designed to use Midas, and I think the 3d result of Midas is better than LeRes? (although i only tested a few images)

The main branch will be Midas and the LeRes branch for LeRes.

@AugmentedRealityCat
Copy link
Collaborator

I see, it became a branch on the original project, and this branch over here was for your own repo.
So now the proper LeRes version of the project would be this one ?
vt-vl-lab#188

@donlinglok1
Copy link
Owner Author

Is the LeRes code now included in the master branch ?

no, I will keep 2 versions separately since the original project is designed to use Midas, and I think the 3d result of Midas is better than LeRes? (although i only tested a few images)

The main branch will be Midas and the LeRes branch for LeRes.

I don’t think they will update the original repo any more, but I also find some interesting issues here,

vt-vl-lab#136

@AugmentedRealityCat
Copy link
Collaborator

AugmentedRealityCat commented Dec 3, 2022

I think the 3d result of Midas is better than LeRes?

Definitely NOT.
LeRes is much better. Much more detailed, much more accurate. It's better in every way.

EDIT: look at this ! This is LeRes. Do you have any result from Midas that are looking as good as that that I may have missed somehow ? It is way better than anything else I've tested so far.
https://user-images.githubusercontent.com/114955776/204782473-18ebe02c-1c1a-430c-863c-d85260f0dd49.png

@donlinglok1
Copy link
Owner Author

I think the 3d result of Midas is better than LeRes?

Definitely NOT. LeRes is much better. Much more detailed, much more accurate. It's better in every way.

EDIT: look at this ! This is LeRes. Do you have any result from Midas that are looking as good as that that I may have missed somehow ? It is way better than anything else I've tested so far. https://user-images.githubusercontent.com/114955776/204782473-18ebe02c-1c1a-430c-863c-d85260f0dd49.png

I see your point, let's merge the LeRes to the master branch and I will create a MiDas branch for backup.

@donlinglok1 donlinglok1 reopened this Dec 3, 2022
@donlinglok1 donlinglok1 merged commit 2b904f1 into master Dec 3, 2022
@donlinglok1 donlinglok1 deleted the LeRes branch December 3, 2022 03:42
@AugmentedRealityCat
Copy link
Collaborator

I also find some interesting issues here,
vt-vl-lab#136

Do you think we can use that to make your code work even better ?
Honestly, it's already very impressive ! Thank you so much once again for your time and your efforts to make this happen.

@donlinglok1
Copy link
Owner Author

I also find some interesting issues here,
vt-vl-lab#136

Do you think we can use that to make your code work even better ? Honestly, it's already very impressive ! Thank you so much once again for your time and your efforts to make this happen.

I have tested the code form vt-vl-lab#136

https://github.com/donlinglok/3d-photo-inpainting/tree/test

seem the result are the same. so I guess the current change in the master is the best we can do.

@AugmentedRealityCat
Copy link
Collaborator

What are your intentions with this project ? Do you still want to turn it into an extension for Automatic1111 ? If you need a beta tester, I'll be there for you.

@donlinglok1
Copy link
Owner Author

Thank you for the support

I am just interested in the AUTOMATIC1111/stable-diffusion-webui and would like to see if there is any fun and cool technology. So this repo only shares a demo for fun outputs, I didn't have the skill set to build the AI from the beginning yet.

For the extension, I can see there is already some good extension basic on the depth image tech, we will witness how great things happen. Extraltodeus/depthmap2mask#11

@AugmentedRealityCat
Copy link
Collaborator

There is also another project about normal maps, and the one that creates masks from depthmaps.
Maybe you should all get together to produce a new 3D tab for Automatic1111 WebUI ! That would be tremendously popular among users I am sure.

@donlinglok1
Copy link
Owner Author

cool, where is the normal maps repo?

I have also changed the name of the idea request to "3D video/gif" AUTOMATIC1111/stable-diffusion-webui#4268

@AugmentedRealityCat
Copy link
Collaborator

cool, where is the normal maps repo?

Over here:
https://github.com/graemeniedermayer/stable-diffusion-webui-normalmap-script

@AugmentedRealityCat
Copy link
Collaborator

You might want to have a look at this as well:
https://depthplayer.ugocapeto.com/

It's an online player that creates a 3d model from an image + a depthmap. You can then download it as an OBJ, and you can also adjust some parameters, like mesh smoothing and downsampling.

There is more info here: https://3dstereophoto.blogspot.com/2019/01/depthplayerugocapetocom-web-tool-to.html
and they have a repo over here: https://github.com/spite/depth-player

@donlinglok1
Copy link
Owner Author

I see, gen-ing 3D model,

speaking of this, you may try on this,
https://colab.research.google.com/drive/16R6Mwi4lmzdzZDVsF1NdqBX1ScIdU8nW?usp=sharing

The repo is here: https://github.com/nv-tlabs/GET3D

@AugmentedRealityCat
Copy link
Collaborator

The big advantage of the link I provided is that it produces a 3d object with UV coordinates, and it does it in OBJ format. It also has a few adjustment parameters that could be useful if you don't use a 3d app after (I had to because I wanted to export an FBX for a specific engine).
But other than that the 3d photo inpainting algo you adapted for windows should provide better 3d results in my opinion. The inpainting should make a difference.

Also, after testing multiple algorythms, I feel that LeRes is best for things like normal maps where local details are more important, and that for 3d extraction where accurate distances are important, Midas-21 in multi-resolution mode provides the best results. I'll keep on testing as this is all quite preliminary.

@AugmentedRealityCat
Copy link
Collaborator

AugmentedRealityCat commented Dec 8, 2022

Testing an HTML embedding of a 3d model to see it it works (if it's a problem just delete - this is not important)

https://meshvalley.com/embed/6391b4d1fb93daaa5e90289a?play&nofx

@donlinglok1
Copy link
Owner Author

The big advantage of the link I provided is that it produces a 3d object with UV coordinates, and it does it in OBJ format. It also has a few adjustment parameters that could be useful if you don't use a 3d app after (I had to because I wanted to export an FBX for a specific engine). But other than that the 3d photo inpainting algo you adapted for windows should provide better 3d results in my opinion. The inpainting should make a difference.

Also, after testing multiple algorythms, I feel that LeRes is best for things like normal maps where local details are more important, and that for 3d extraction where accurate distances are important, Midas-21 in multi-resolution mode provides the best results. I'll keep on testing as this is all quite preliminary.

This sounds professional, I am just a newbie in 3D modeling, so seems I have much to learn! Thanks for sharing!

Testing an HTML embedding of a 3d model to see it it works (if it's a problem just delete - this is not important)

https://meshvalley.com/embed/6391b4d1fb93daaa5e90289a?play&nofx

I can see 'The Mask' here. LOL

@donlinglok1 donlinglok1 restored the LeRes branch December 29, 2022 08:23
@donlinglok1
Copy link
Owner Author

donlinglok1 commented Jan 5, 2023

Testing an HTML embedding of a 3d model to see it it works (if it's a problem just delete - this is not important)

https://meshvalley.com/embed/6391b4d1fb93daaa5e90289a?play&nofx

https://make3d.app/?ref=theresanaiforthat
@AugmentedRealityCat this one are similar and fast

@AugmentedRealityCat
Copy link
Collaborator

https://make3d.app/?ref=theresanaiforthat @AugmentedRealityCat this one are similar and fast

This is extremely slow - I suppose it runs on the CPU, else there must be something wrong as I'm still waiting for the first image to process.

My current workflow is to use the DepthMap extension for Automatic1111 and to import the resulting depthmap into C4d to drive a polygon displacement effect. This is almost instant: it takes a few seconds to load and interpret a new depthmap, but you have to render those depthmaps in A1111 first.

@donlinglok1
Copy link
Owner Author

https://make3d.app/?ref=theresanaiforthat @AugmentedRealityCat this one are similar and fast

This is extremely slow - I suppose it runs on the CPU, else there must be something wrong as I'm still waiting for the first image to process.

My current workflow is to use the DepthMap extension for Automatic1111 and to import the resulting depthmap into C4d to drive a polygon displacement effect. This is almost instant: it takes a few seconds to load and interpret a new depthmap, but you have to render those depthmaps in A1111 first.

i see, i still don't have time to try on the new extension nearly updated, but it seems good base on your experience👍

@AugmentedRealityCat
Copy link
Collaborator

In fact, this is with the previous version of the extension - just plain depthmap based displacement, not actual 3d-inpainting. I have not had the time to test the latest version either ! Hopefully I'll get to do that over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants