Fixed render example #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, clicking the space between links (the parent container) broke the highlighting
|
thanks ! much appreciated |
donseba
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pullrequest fixes two issuse in the 'render' example:
When trying out the example, I noticed that route handling in main.go was assigned to the http module instead of the mux object, which resulted in 404 responses for me for all routes.
Clicking the space between the 'Home' and 'Child' links in the sidebar results in the parent container receiving the bg-blue-500 class, breaking the highlighting system for subsequent clicks.
Moving the hyperscript snippet to the link item fixed this.