Fix codecov and test failures #662
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robtaylor
force-pushed
the
fix-codecov
branch
3 times, most recently
from
541ef0a
to
0192719
Compare
robtaylor
force-pushed
the
fix-codecov
branch
from
0192719
to
d958342
Compare
|
See #667 |
robtaylor
changed the title
|
Updated PR to fix two issues causing test and coverage failure:
|
robtaylor
force-pushed
the
fix-codecov
branch
4 times, most recently
from
ee6c821
to
af026a1
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #662 +/- ##
========================================
Coverage 96.24% 96.24%
========================================
Files 41 41
Lines 5220 5220
Branches 1226 1226
========================================
Hits 5024 5024
Misses 124 124
Partials 72 72 ☔ View full report in Codecov by Sentry. |
robtaylor
force-pushed
the
fix-codecov
branch
2 times, most recently
from
0c56a27
to
04e01dc
Compare
|
Ugh, this changing viewbox parameter in the generated svg is killing me!! |
robtaylor
force-pushed
the
fix-codecov
branch
3 times, most recently
from
3525c72
to
3e9d825
Compare
robtaylor
force-pushed
the
fix-codecov
branch
2 times, most recently
from
74a7d65
to
f8b0de2
Compare
It's proved difficult to get plantuml to generate the same svg output on all target platforms, with non-obvious factors effecting dimensions in various aspects of its output. This switches the test cases to use embedded png output instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue with linux showing as failing.