feat: support generating correct types for @oneOf input types
#7886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b4cf959 The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The latest changes of this PR are available as alpha in npm (based on the declared |
benjie
reviewed
May 25, 2022
packages/plugins/typescript/typescript/tests/typescript.spec.ts
Outdated
Show resolved
Hide resolved
|
oneOf requires that all fields are nullable in the schema, and promises/requires that exactly one will be non-null at run time. You have tests for non-null fields on a oneOf; that’s expressly forbidden in the spec. |
n1ru4l
commented
May 26, 2022
packages/plugins/other/visitor-plugin-common/src/base-types-visitor.ts
Outdated
Show resolved
Hide resolved
n1ru4l
commented
May 26, 2022
n1ru4l
commented
Jun 6, 2022
n1ru4l
commented
Jun 6, 2022
n1ru4l
commented
Jun 6, 2022
dotansimha
approved these changes
Jun 6, 2022
|
@n1ru4l @dotansimha Can this change be published in a prerelease? |
|
@purkhusid You can use the versions here; |
|
@ardatan Ah, thought some commits were missing from that release but it seems like everything is there. Thanks! |
|
Sadly this is breaking for me and blocking me from upgrading in general, see #7938 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for the
@oneOfdirective on input object types.Things to consider:
Should we make this available behind a flag?
@onOfis still in the RFC stage and the behavior could change slightly. Should we, therefore, make this opt-in?References:
@oneOfdirective graphql/graphql-js#3513 (comment)