Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to the new urql major #8323

Merged
merged 3 commits into from
Sep 4, 2022
Merged

Conversation

JoviDeCroock
Copy link
Contributor

@JoviDeCroock JoviDeCroock commented Sep 4, 2022

Description

We have bumped our major, for types the biggest change is our new variables type urql-graphql/urql#2607

Related #8276

Seeing is we see issues like urql-graphql/urql#2668 or urql-graphql/urql#2639 as well 😅

Type of change

Have left this in in case we see issues in the tests 😅 but should be good unless the new variables type includes issues, we have tested it on our side and it didn't but it still could

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Ran locally on our application

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2022

🦋 Changeset detected

Latest commit: 98c6c90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-codegen/typescript-urql-graphcache Minor
@graphql-codegen/urql-svelte-operations-store Minor
@graphql-codegen/typescript-urql Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dotansimha
Copy link
Owner

Thanks @JoviDeCroock ! Will merge and release when CI clears :)

@JoviDeCroock
Copy link
Contributor Author

If I can do anything about the failing linting check LMK, can't tell what's wrong atm 😅

@dotansimha
Copy link
Owner

If I can do anything about the failing linting check LMK, can't tell what's wrong atm 😅

That's my bad, we can ignore for now :)

@dotansimha dotansimha merged commit 3eb273e into dotansimha:master Sep 4, 2022
@dotansimha
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants