-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix @oneOf support broken with declaration kind other than type #8586
Fix @oneOf support broken with declaration kind other than type #8586
Conversation
🦋 Changeset detectedLatest commit: 60270c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, can you please add a changeset that describes this change?
@n1ru4l Added a changeset. I hope I did everything correct. |
@levrik waiting for another review from @charlypoly - then we should be fine :) |
Thanks a lot for getting this merged! |
@levrik Thank you for fixing this! 🙇🏼 |
On #8024 it was suggested to remove support for
declarationKind
all together.Since this is a breaking change and probably won't happen soon and things are currently broken if using a
declarationKind
other thantype
, I would like to propose hard-coding@oneOf
declarations totype
, regardless of the configureddeclarationKind
astype
is the only one working.Fixes #7938