Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @oneOf support broken with declaration kind other than type #8586

Merged
merged 6 commits into from
Nov 15, 2022
Merged

Fix @oneOf support broken with declaration kind other than type #8586

merged 6 commits into from
Nov 15, 2022

Conversation

levrik
Copy link
Contributor

@levrik levrik commented Nov 8, 2022

On #8024 it was suggested to remove support for declarationKind all together.
Since this is a breaking change and probably won't happen soon and things are currently broken if using a declarationKind other than type, I would like to propose hard-coding @oneOf declarations to type, regardless of the configured declarationKind as type is the only one working.

Fixes #7938

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2022

🦋 Changeset detected

Latest commit: 60270c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@graphql-codegen/visitor-plugin-common Patch
@graphql-codegen/typescript Patch
@graphql-codegen/typescript-document-nodes Patch
@graphql-codegen/gql-tag-operations Patch
@graphql-codegen/typescript-operations Patch
@graphql-codegen/typescript-resolvers Patch
@graphql-codegen/typed-document-node Patch
@graphql-codegen/graphql-modules-preset Patch
@graphql-codegen/client-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@levrik levrik changed the title Fix #7938 Fix oneOf support broken with declaration kind other than type Nov 8, 2022
@levrik levrik mentioned this pull request Nov 8, 2022
4 tasks
Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, can you please add a changeset that describes this change?

@levrik
Copy link
Contributor Author

levrik commented Nov 8, 2022

@n1ru4l Added a changeset. I hope I did everything correct.

@levrik levrik requested a review from n1ru4l November 11, 2022 07:15
@levrik levrik changed the title Fix oneOf support broken with declaration kind other than type Fix @oneOf support broken with declaration kind other than type Nov 11, 2022
@n1ru4l n1ru4l requested a review from charlypoly November 11, 2022 14:00
@n1ru4l
Copy link
Collaborator

n1ru4l commented Nov 11, 2022

@levrik waiting for another review from @charlypoly - then we should be fine :)

@charlypoly charlypoly merged commit ef4c2c9 into dotansimha:master Nov 15, 2022
@levrik levrik deleted the fix-oneof-declaration-kind branch November 15, 2022 14:01
@levrik
Copy link
Contributor Author

levrik commented Nov 15, 2022

Thanks a lot for getting this merged!

@charlypoly
Copy link
Contributor

@levrik Thank you for fixing this! 🙇🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@oneOf support broken with interfaces
3 participants