Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom mappers w. placeholder will apply omit #9110

Merged
merged 5 commits into from
Mar 6, 2023

Conversation

gilgardosh
Copy link
Collaborator

@gilgardosh gilgardosh commented Mar 5, 2023

Fixes #9043

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2023

🦋 Changeset detected

Latest commit: 4fe1313

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@graphql-codegen/visitor-plugin-common Patch
@graphql-codegen/typescript-resolvers Patch
@graphql-codegen/typescript-document-nodes Patch
@graphql-codegen/gql-tag-operations Patch
@graphql-codegen/typescript-operations Patch
@graphql-codegen/typed-document-node Patch
@graphql-codegen/typescript Patch
@graphql-codegen/graphql-modules-preset Patch
@graphql-codegen/client-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gilgardosh gilgardosh requested a review from saihaj March 5, 2023 15:22
@gilgardosh gilgardosh self-assigned this Mar 5, 2023
@saihaj
Copy link
Collaborator

saihaj commented Mar 5, 2023

Can we add a test for this?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-codegen/visitor-plugin-common 3.0.2-alpha-20230306131459-4fe131367 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-document-nodes 3.0.2-alpha-20230306131459-4fe131367 npm ↗︎ unpkg ↗︎
@graphql-codegen/gql-tag-operations 2.0.2-alpha-20230306131459-4fe131367 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-operations 3.0.2-alpha-20230306131459-4fe131367 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-resolvers 3.1.1-alpha-20230306131459-4fe131367 npm ↗︎ unpkg ↗︎
@graphql-codegen/typed-document-node 3.0.2-alpha-20230306131459-4fe131367 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript 3.0.2-alpha-20230306131459-4fe131367 npm ↗︎ unpkg ↗︎
@graphql-codegen/client-preset 2.1.1-alpha-20230306131459-4fe131367 npm ↗︎ unpkg ↗︎
@graphql-codegen/graphql-modules-preset 3.1.1-alpha-20230306131459-4fe131367 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023

💻 Website Preview

The latest changes are available as preview in: https://93a0a095.graphql-code-generator.pages.dev

@gilgardosh gilgardosh marked this pull request as draft March 5, 2023 15:33
@gilgardosh gilgardosh marked this pull request as ready for review March 5, 2023 17:05
@gilgardosh
Copy link
Collaborator Author

Can we add a test for this?

It's already in the scope of current tests, see the diffs on packages/plugins/typescript/resolvers/tests/mapping.spec.ts
@saihaj

Copy link
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@saihaj saihaj merged commit ba0610b into master Mar 6, 2023
@saihaj saihaj deleted the custom-mappers-with-T-fix branch March 6, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolver: Using {T} in a custom mapper loses Omits
2 participants