Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init): change default output directory to src/gql/, from src/gql #9158

Closed
wants to merge 1 commit into from

Conversation

MH4GF
Copy link

@MH4GF MH4GF commented Mar 12, 2023

Description

change default output directory to src/gql/, because client-preset must end with / or an error will occur.

if (!isOutputFolderLike(options.baseOutputDir)) {
throw new Error('[client-preset] target output should be a directory, ex: "src/gql/"');
}

Related #9157

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested by snapshot test of output codegen.ts
    • For a more rigorous approach, it might be desirable to write a test that executes executeCodegen() using the configuration file generated by default, but I decided not to go that far.

Test Environment:

  • OS: macOS
  • NodeJS: 16.16.0
  • graphql version: 16.6.0
  • @graphql-codegen/* version(s): 3.2.1

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2023

⚠️ No Changeset found

Latest commit: 18c2ef1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MH4GF
Copy link
Author

MH4GF commented Apr 22, 2023

fixed: #9280

@MH4GF MH4GF closed this Apr 22, 2023
@MH4GF MH4GF deleted the fix-default-output-directory branch April 22, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant