Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] Add complex Interface test cases for typescript-resolvers #9228

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

eddeee888
Copy link
Collaborator

@eddeee888 eddeee888 commented Mar 26, 2023

Description

This PR extends resolversTestingSchema with Interfaces with nested union and self-referencing Interfaces.
This creates the baseline tests to help us ensure correctness when extracting ResolversInterfaceTypes (Similar to what was done in the ResolversUnionTypes PR )

Type of change

Please delete options that are not relevant.

  • Extend and baseline tests

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Update tests

Test Environment:

Not applicable

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2023

🦋 Changeset detected

Latest commit: 459bb1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-codegen/cli 3.3.0-alpha-20230326044853-459bb1e12 npm ↗︎ unpkg ↗︎
@graphql-codegen/visitor-plugin-common 3.1.0-alpha-20230326044853-459bb1e12 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-document-nodes 3.0.3-alpha-20230326044853-459bb1e12 npm ↗︎ unpkg ↗︎
@graphql-codegen/gql-tag-operations 3.0.0-alpha-20230326044853-459bb1e12 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-operations 3.0.3-alpha-20230326044853-459bb1e12 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-resolvers 3.2.0-alpha-20230326044853-459bb1e12 npm ↗︎ unpkg ↗︎
@graphql-codegen/typed-document-node 4.0.0-alpha-20230326044853-459bb1e12 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript 3.0.3-alpha-20230326044853-459bb1e12 npm ↗︎ unpkg ↗︎
@graphql-codegen/client-preset 3.0.0-alpha-20230326044853-459bb1e12 npm ↗︎ unpkg ↗︎
@graphql-codegen/graphql-modules-preset 3.1.2-alpha-20230326044853-459bb1e12 npm ↗︎ unpkg ↗︎
@graphql-codegen/testing 2.0.2-alpha-20230326044853-459bb1e12 npm ↗︎ unpkg ↗︎
@graphql-codegen/plugin-helpers 4.2.0-alpha-20230326044853-459bb1e12 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://f9a3946e.graphql-code-generator.pages.dev

@eddeee888 eddeee888 merged commit a5ec5af into master Mar 27, 2023
@eddeee888 eddeee888 deleted the add-nested-union-and-interface-cases branch March 27, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants