Avoid wrapping args with partial when avoiding optionals #9673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes it so arguments don't get wrapped with a
Partial
when configured to avoid optionals for input values. Without this change,avoidOptionals = true
ends up being inconsistent since it will still use optional input values in the case there is only nullable arguments.Related #9438
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added a test that avoid optionals does not wrap the arguments with a partial when configured.
Test Environment:
@graphql-codegen/typescript-resolvers
: 4.0.1Checklist:
Further comments
I think this should be fairly uncontroversial since it is preserving the intention of the avoid optionals config.