Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-preset] Preserving Array<T> or ReadonlyArray<T> in useFragment() data #9804

Merged
merged 6 commits into from
Jun 13, 2024

Conversation

rachel-church
Copy link
Contributor

@rachel-church rachel-church commented Jan 3, 2024

Description

Updating the useFragment() (or renamed equivalent) type overload to preserve the readonly or lack of modifier when an array is provided as the data argument.

Related #(issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: 9ad029b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/client-preset Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@n1ru4l
Copy link
Collaborator

n1ru4l commented Mar 4, 2024

Hey @rachel-church, can you have a look at the failing tests?

@rachel-church
Copy link
Contributor Author

Hey @rachel-church, can you have a look at the failing tests?

Done!

@n1ru4l
Copy link
Collaborator

n1ru4l commented Jun 13, 2024

@rachel-church Thank you for the contribution!

@n1ru4l n1ru4l merged commit 5e594ef into dotansimha:master Jun 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants