This repository has been archived by the owner on Oct 5, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three main things, as explained by each of the commits' messages.
OAuth2OpenID authorization page -> accept -> logged in [notice the change?])Some new configuration is also required if wanting to use OpenID (either instead of or in addition to OAuth2). This configuration consists of setting the address to an OpenID-capable host, supplying the client id for a valid client on the host and a redirect uri. No need to specify where the authorization, token, refresh and logout endpoints are -- they're fetched automatically. To actually activate the OIDC client it is needed to set
SDF_OIDC
totrue
.💡 Suggestion: Read the diff of each commit on its own, they should have self-explanatory messages and it reduces the scope of the changes.
Resolves #131