fix: 🐛 updating src doesn't clear previously loaded states

dotlottie · Sep 6, 2023 · 5acb38c · 5acb38c
1 parent 022a1f0
commit 5acb38c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/packages/common/src/dotlottie-loader.ts b/packages/common/src/dotlottie-loader.ts
@@ -47,6 +47,7 @@ export class DotLottieLoader {
   }
 
   public async loadFromUrl(url: string): Promise<void> {
+    this.clearCache();
     const response = await fetch(url, {
       method: 'GET',
       mode: 'cors',
@@ -93,6 +94,7 @@ export class DotLottieLoader {
   }
 
   public loadFromLottieJSON(json: Record<string, unknown>): void {
+    this.clearCache();
     if (!isValidLottieJSON(json)) {
       throw new Error('Invalid lottie JSON');
     }
@@ -114,6 +116,7 @@ export class DotLottieLoader {
   }
 
   public async loadFromArrayBuffer(arrayBuffer: ArrayBuffer): Promise<void> {
+    this.clearCache();
     this._dotLottie = await loadFromArrayBufferUtil(arrayBuffer);
 
     const manifest = await getManifestUtil(this._dotLottie);
@@ -204,4 +207,10 @@ export class DotLottieLoader {
 
     return stateMachine;
   }
+
+  public clearCache(): void {
+    this._stateMachinesMap.clear();
+    this._themeMap.clear();
+    this._animationsMap.clear();
+  }
 }
diff --git a/packages/common/src/dotlottie-player.ts b/packages/common/src/dotlottie-player.ts
@@ -188,7 +188,7 @@ export class DotLottiePlayer {
 
   private _visibilityPercentage: number = 0;
 
-  protected _stateMachineManager?: DotLottieStateMachineManager;
+  protected _stateMachineManager: DotLottieStateMachineManager | undefined;
 
   public constructor(
     src: string | Record<string, unknown>,
@@ -443,6 +443,7 @@ export class DotLottiePlayer {
     this._src = src;
     this._activeAnimationId = undefined;
     this._currentAnimationId = undefined;
+    this._stateMachineManager = undefined;
     this.load();
   }