Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/manifest options #228

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Fix/manifest options #228

merged 4 commits into from
Sep 11, 2023

Conversation

afsalz
Copy link
Contributor

@afsalz afsalz commented Sep 11, 2023

Description

  • added setPlayerState function to use within common code
  • fixed manifest options not picked up on next()
  • Fixed manifest options not picked up on selecting animations from popover
  • Added missing tests for both issues

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Docs: Documentation updates (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested my changes on the player-component and React player.

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023

🦋 Changeset detected

Latest commit: 190c253

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@dotlottie/player-component Patch
@dotlottie/react-player Patch
@dotlottie/common Patch
next Patch
nuxt-app Patch
react Patch
vue Patch
web Patch
dotlottie-playground Patch
react-player-next Patch
react-player-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/common/dist/index.js 6.92 KB (0%) 139 ms (0%) 214 ms (+44.59% 🔺) 352 ms
packages/player-component/dist/dotlottie-player.mjs 29.86 KB (+0.52% 🔺) 598 ms (+0.52% 🔺) 179 ms (-51.87% 🔽) 776 ms

@afsalz afsalz force-pushed the fix/manifest-options branch from 9dd99e6 to 190c253 Compare September 11, 2023 10:39
@afsalz afsalz merged commit 60262ef into master Sep 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants