Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 tsconfig jsx compile option for react 16.8 compatibility #285

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

theashraf
Copy link
Member

@theashraf theashraf commented Dec 28, 2023

Description

The 'jsx' option in tsconfig.json has been changed from 'react-jsx' to 'react', enabling the package to be used across a wider range of React versions

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Docs: Documentation updates (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested my changes on the player-component and React player.

Copy link

changeset-bot bot commented Dec 28, 2023

🦋 Changeset detected

Latest commit: 20538a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@dotlottie/react-player Patch
dotlottie-playground Patch
react-player-next Patch
react-player-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/common/dist/index.js 7.45 KB (0%) 149 ms (0%) 235 ms (+42.38% 🔺) 384 ms
packages/player-component/dist/dotlottie-player.mjs 31.73 KB (0%) 635 ms (0%) 276 ms (-10.93% 🔽) 911 ms

@theashraf theashraf merged commit 52e45e3 into master Dec 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant