Fix/issue 291 #293
Merged
Fix/issue 291 #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the trigger of loopComplete when its not playing
🦋 Changeset detectedLatest commit: a74e762 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
theashraf
approved these changes
Jan 17, 2024
Comment on lines
+1600
to
+1608
| // Fix: First loopComplete is not fired by lottie-web when direction is -1 | ||
| if (this.currentState === PlayerState.Playing && this._loop && this._lottie.playCount === 0) { | ||
| this._lottie.triggerEvent('loopComplete', { | ||
| currentLoop: this._lottie.playCount, | ||
| direction: this.direction, | ||
| totalLoops: typeof this.loop === 'number' ? this.loop : Infinity, | ||
| type: 'loopComplete', | ||
| }); | ||
| } |
There was a problem hiding this comment.
if lottie-web fixes this issue from their end, would that make the loopComplete fire twice when playing in the reverse direction ?
There was a problem hiding this comment.
yeah it could fire twice. we may have to revert this change once they fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist